-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cancel button to the QuestionnaireFragment #1829
Comments
@Itskiprotich have you been facing issues with the up/back button that currently cancels the questionnaire collection? @shelaghm FYI |
@omarismail94 the up/back button works well. However, for uniformity design-wise, I find it ideal to have both submit and cancel buttons. |
Thanks @Itskiprotich for raising this issue and creating the PR. @shelaghm @rowo @joiskash @kunjan8794 please note the change that is being proposed in this ticket. I do feel this is a very reasonable feature, but also something that would require an option to turn it on/off. One thing I'm not totally sure is just whether this is something that should be default to on or off? Any thoughts? Also I don't know if it's a good idea to limit this to single page questionnaire... ? should paginated questionnaires also have an option to include a cancel button? if so should it be on the first page or every page? if every page how do we position this button together with the prev/next buttons? |
This looks good! I would vote for default on |
Discussion w/ Jing and team:
|
@shelaghm I have updated the feature to include the confirmation dialog within the SDC. |
Thank you! Looks great @Itskiprotich |
Is your feature request related to a problem? Please describe.
Provide an option where a user can cancel the data collection
Describe the solution you'd like
Add a cancel button
Describe alternatives you've considered
N/A
Additional context
Would you like to work on the issue?
Yes
The text was updated successfully, but these errors were encountered: