-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review button doesn't validate the last page of a paginated questionnaire #1682
Comments
@f-odhiambo Can you take a look and advice? |
@KhumboLihonga which version of the sdc lib are you using? |
@jingtang10 |
i see this is opensrp's fork. can you try depending on beta06 of the sdc lib? |
@LZRS Could you look into updating this |
@jingtang10 we tried using beta06 as per opensrp/fhircore#1836 but it's still not working as shown in the video below. 20221115_104422.mp4 |
@KhumboLihonga @jingtang10 PR-1671 would solve this issue. Its not merged yet. |
@aditya-07 @jingtang10 I tested this once again since #1671 has now been merged but I'm still facing the same issue. Here is a video showing the issue after testing the it again. And here is the questionnaire that I used. |
i have verified on HEAD, this is still broken. |
@jingtang10 thanks for verifying this. Is there an ETA on when this could get resolved? |
Describe the bug
In a paginated questionnaire that uses the entryMode extension set to
prior-edit
, the active page needs to be valid before moving to the next page. When used in conjunction with the review functionality, the next button turns into a review button on the final page of the paginated questionnaire. And when this review button is tapped, no validation takes place on this page. An example of this is shown in the video below.Component
SDC Library
To Reproduce
N/A
Expected behavior
I expect the review button to validate the last page before allowing the user to proceed to the review page.
Screenshots
In the video below, the user is first tapping the next button on each page to show the validation erros before entering the required information. Once this is done, the next button is tapped to proceed to the next page. But on the final page (with the heading CHW Assignment), on tapping the review button, no validation is done.
20221020_120603.mp4
Smartphone (please complete the following information):
Additional context
Here is the questionnaire being used in the video:
The text was updated successfully, but these errors were encountered: