Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement slider step value extension #1260

Closed
Tarun-Bhardwaj opened this issue Mar 25, 2022 · 13 comments · Fixed by #1630 or #1660
Closed

Implement slider step value extension #1260

Tarun-Bhardwaj opened this issue Mar 25, 2022 · 13 comments · Fixed by #1630 or #1660
Assignees
Labels
effort:small Small effort - 2 days P3 Low priority issue type:enhancement New feature or request ux testing

Comments

@Tarun-Bhardwaj
Copy link

Tarun-Bhardwaj commented Mar 25, 2022

Current issue
By default, the slider step increment is 10. It should be controllable from the questionnaire. This required implementation of an extension: http://build.fhir.org/extension-questionnaire-sliderstepvalue.html

Describe the feature
When using the slider, I should be able to control the steps increment

Component
Core library, SDC library, reference app, or SDC gallery app

Expected behavior
For example, when specifying a question like, how many previous pregnancies have you had, the slider should step up in increments of 1 (default is 10) - see screenshot of current behaviour below)

Screenshots
image

Smartphone (please complete the following information):

  • Device: [e.g. Pixel4a emulator]
  • Android version: [e.g. Settings -> About phone -> Android version]
  • Build number: [e.g. Settings -> About phone -> Build number]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Would you like to work on the issue?
Assigning this bug to @santosh-pingle since he is already working on catalog app changes.

@santosh-pingle
Copy link
Collaborator

To fix this issue SDC library should start supporting slider step value extension.
At this moment it is not implemented in sdc library.
http://build.fhir.org/extension-questionnaire-sliderstepvalue.html

@fredhersch fredhersch added type:enhancement New feature or request and removed type:bug Something isn't working labels Mar 25, 2022
@fredhersch fredhersch changed the title Instead of single steps, the slider in catalog steps up in multiples of 10 Implement slider step value extension Mar 25, 2022
@fredhersch
Copy link
Collaborator

Thanks @santosh-pingle is this an issue you can pick up?

@santosh-pingle
Copy link
Collaborator

Sure, I will work on it.

@Tarun-Bhardwaj Tarun-Bhardwaj added P3 Low priority issue effort:small Small effort - 2 days Data capture and removed Triage labels Mar 30, 2022
@fredhersch
Copy link
Collaborator

Any update here @santosh-pingle

@santosh-pingle
Copy link
Collaborator

@fredhersch I have not started implementation yet as occupied with other issues, please let me check with @Tarun-Bhardwaj and @jingtang10

@fredhersch
Copy link
Collaborator

fredhersch commented Aug 29, 2022

@jingtang10 @shelaghm I think this should be higher priority. At the moment, the slider control is effectively not useful. Can we review this? Perhaps this is could be a "help wanted" issue?

cc: @Tarun-Bhardwaj

@shelaghm
Copy link

Based on internal accessibility research, the usability of the slider is enhanced by pairing the slider with a text field.
I strongly recommend adding a text field with the slider. I've pasted a link to the research in our internal chat.
Screen Shot 2022-08-29 at 10 58 47

@shelaghm
Copy link

How to clear selection/answer for the slider? Do we have a pattern for this?

@Tarun-Bhardwaj Tarun-Bhardwaj moved this from Backlog to Icebox in Android FHIR SDK Sep 16, 2022
@shelaghm shelaghm self-assigned this Sep 21, 2022
@santosh-pingle
Copy link
Collaborator

looking into it.

@fredhersch fredhersch moved this from Icebox to Backlog in Android FHIR SDK Sep 23, 2022
@fredhersch fredhersch moved this from Backlog to Icebox in Android FHIR SDK Sep 23, 2022
@santosh-pingle
Copy link
Collaborator

santosh-pingle commented Sep 23, 2022

Based on internal accessibility research, the usability of the slider is enhanced by pairing the slider with a text field. I strongly recommend adding a text field with the slider. I've pasted a link to the research in our internal chat. Screen Shot 2022-08-29 at 10 58 47

@shelaghm
the usability of the slider is enhanced by pairing the slider with a text field, what are the use case you would like to implement here?
Can you please list out those uses cases e.g

  • Show current slider value in the input text field?

@fredhersch fredhersch moved this from Icebox to Backlog in Android FHIR SDK Sep 23, 2022
@fredhersch
Copy link
Collaborator

fredhersch commented Sep 23, 2022

Will put this on hold until after Ux testing to determine prioritisation.

To do:

  • Hide slider example from SDC category app
  • Update the wiki documentation to indicate level of support for sliders

cc: @santosh-pingle @shelaghm

@shelaghm
Copy link

Thanks @fredhersch for the prioritization.

@santosh-pingle the primary use case for adding the slider text box is for accessibility best practises. Sliders are hard to interact with for people who are visually impaired and who use screen readers, it is also challenging for anyone who has motor control limitations. Having the text box also makes it easier for other people who know what number they want to enter to be able to just type in the answer instead of fiddling with the slider.

The slider and the number in the box should match each other. So if you move the slider, the number should update in the text box. Likewise, if you enter text in the box, it should update on the slider.

@santosh-pingle
Copy link
Collaborator

santosh-pingle commented Sep 26, 2022

Will put this on hold until after Ux testing to determine prioritisation.

To do:

  • Hide slider example from SDC category app
  • Update the wiki documentation to indicate level of support for sliders

cc: @santosh-pingle @shelaghm

Sure.
I will not create PR for local changes of slider-step extension implementation, until this issue get prioritised.
Once issue get prioritised then start working on use case which @shelaghm has asked regarding textfield, slider pairing.

I will create PR for temporary change to hide slider component workflow in catalog app.

Repository owner moved this from Backlog to Complete in Android FHIR SDK Sep 27, 2022
@jingtang10 jingtang10 reopened this Sep 29, 2022
Repository owner moved this from Complete to New in Android FHIR SDK Sep 29, 2022
@jingtang10 jingtang10 moved this from New to Backlog in Android FHIR SDK Sep 29, 2022
Repository owner moved this from Backlog to Complete in Android FHIR SDK Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:small Small effort - 2 days P3 Low priority issue type:enhancement New feature or request ux testing
Projects
Status: Complete
5 participants