Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data capture, add subtitle text to the questionnaire item view. #1113

Closed
santosh-pingle opened this issue Feb 4, 2022 · 5 comments · Fixed by #1222
Closed

Data capture, add subtitle text to the questionnaire item view. #1113

santosh-pingle opened this issue Feb 4, 2022 · 5 comments · Fixed by #1222
Assignees
Labels
type:enhancement New feature or request

Comments

@santosh-pingle
Copy link
Collaborator

santosh-pingle commented Feb 4, 2022

Is your feature request related to a problem? Please describe.

As per new ux/ui guideline mentioned in the figma, it is expected to show subtitle text below the questionnaire text.

Action items

  • Add subtitle text to the questionnaire item in the questionnaire json to be shown in the form.
  • Add textview to show subtitle text in all sdc questionnaire widgets.

We can refer below design guideline, where select one is considered as subtitle text.

Screen Shot 2022-02-04 at 11 43 42 AM

Describe the solution you'd like

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

@santosh-pingle santosh-pingle changed the title Data capture, Add subtitle text to questionnaire item. Data capture, add subtitle text to the questionnaire item view. Feb 4, 2022
@santosh-pingle santosh-pingle self-assigned this Mar 2, 2022
@jingtang10
Copy link
Collaborator

@santosh-pingle
Copy link
Collaborator Author

santosh-pingle commented Mar 7, 2022

@jingtang10
If nested display item is used to show subtitle along with question text, then it also creates separate questionItemViewItem to display another question item, and its conflict.
e.g

"item": [
    {
      "linkId": "1",
      "text": "Have you taken a pregnancy test?",
      "type": "boolean",
      "item": [
        {
          "linkId": "1-select-one",
          "text": "Select one",
          "type": "display"
        }
      ]
    }
  ]

It creates 2 questionItemViewItems, where 2nd questionItemView item with linkId 1-select-one is not required in this case.

@santosh-pingle
Copy link
Collaborator Author

santosh-pingle commented Mar 7, 2022

It is possible to hide/ disable nested display questionnaire item.
But then developer has to explicitly add hidden extension or make it disable.
Nested display questionnaire item is only added to provide subtitle text to parent question. Therefore, it must not create questionnaire item view item for nested display item. If nested display item not enabled then view item will not be created.

If display item is present in group item then it should not be considered nested display item for subtitle text, this special case need to be handled.

@santosh-pingle
Copy link
Collaborator Author

Screen Shot 2022-03-09 at 1 28 07 PM

@santosh-pingle
Copy link
Collaborator Author

It is possible to hide/ disable nested display questionnaire item. But then developer has to explicitly add hidden extension or make it disable. Nested display questionnaire item is only added to provide subtitle text to parent question. Therefore, it must not create questionnaire item view item for nested display item. If nested display item not enabled then view item will not be created.

If display item is present in group item then it should not be considered nested display item for subtitle text, this special case need to be handled.

Approach 2 :
Do not include nested display item to QuestionnaireItemViewItemList at the time of questionnaire state creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants