Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not return 500 when pulling private repo failed #1241

Closed
storyicon opened this issue May 24, 2019 · 1 comment
Closed

Should not return 500 when pulling private repo failed #1241

storyicon opened this issue May 24, 2019 · 1 comment
Labels
proposal A proposal for discussion and possibly a vote

Comments

@storyicon
Copy link

In order to match the golang on the master branch, I think it should probably return 404

Dilemma: https://github.com/storyicon/gos/blob/master/docs/on-goproxy.md
Related issue: golang/go#31913
@storyicon storyicon mentioned this issue May 24, 2019
Closed
@marpio
Copy link
Member

marpio commented May 24, 2019 •
edited
Loading

@storyicon
Wouldn't that be covered by #1211 and one of the DownloadModes?

cc: @marwan-at-work

@marpio marpio added proposal A proposal for discussion and possibly a vote question Further information is requested and removed question Further information is requested labels May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal A proposal for discussion and possibly a vote
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marpio @storyicon