Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: x/tools/cmd/auth: tag and delete #70872

Open
samthanawalla opened this issue Dec 16, 2024 · 6 comments
Open

proposal: x/tools/cmd/auth: tag and delete #70872

samthanawalla opened this issue Dec 16, 2024 · 6 comments
Labels
Milestone

Comments

@samthanawalla
Copy link
Contributor

samthanawalla commented Dec 16, 2024

Proposal Details

The x/tools/cmd/auth directory is obsolete. We've integrated its GOAUTH implementation directly into src/cmd/go/internal/auth as part of issue #26232. This means we no longer need to maintain the separate reference implementation in x/tools/cmd/auth.

Therefore, let's delete x/tools/cmd/auth

@adonovan
Copy link
Member

BTW, the process for deleting a package is to create a new module in its subdirectory, release it by tagging a version, and then delete it. That way any project that imports it will automatically depend on the deleted module (after upgrading) and will continue to build. See for example #59676.

@adonovan adonovan moved this to Incoming in Proposals Dec 16, 2024
@shashank-priyadarshi
Copy link

@samthanawalla can I please take this up?

@samthanawalla
Copy link
Contributor Author

@samthanawalla can I please take this up?

That would be great! However the proposal needs to get accepted first

@rsc rsc changed the title proposal: x/tools/cmd/auth: cleanup old code proposal: x/tools/cmd/auth: tag and delete Feb 5, 2025
@rsc
Copy link
Contributor

rsc commented Feb 5, 2025

It looks like netrcauth and gitauth are integrated into the go command but not cookieauth. Should we leave cookieauth around or provide it somewhere else?

@rsc
Copy link
Contributor

rsc commented Feb 5, 2025

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

@rsc rsc moved this from Incoming to Active in Proposals Feb 5, 2025
@samthanawalla
Copy link
Contributor Author

I think it makes sense to move cookieauth somewhere else so as to not confuse people but I am not sure where.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Active
Development

No branches or pull requests

5 participants