proposal: vendor: allow packages named vendor

[gucio321]

Proposal Details

Hi
For context, please read this: https://github.com/gucio321/vendor-package-issue/tree/master

My proposal is to allow packages in non-root directories to be called vendor for example:

.
├── go.mod
├── m1.go
└── pkg
    └── vendor
        └── vendor.go

3 directories, 3 files

[gabyhelp]

Related Issues

• Proposal: allow importing of vendored package even not if not in the same subtree #15162 (closed)
• cmd/go: non-top-level packages ending in "/vendor" are omitted from module zip files #37397 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gucio321]

#37397 sounds similar. if so this is a regression

[seankhliao]

This is a dupe of #37397, it will only work after 1.24 (scheduled for next february).

[gucio321]

tysm and sorry - I didn't look at dates careful enough 😄

[gucio321]

@seankhliao this is not fixed although go 1.24 is already there.

I'm still getting this:

go: finding module for package github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/test/config_info
go: finding module for package github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/test/de_fuzz
go: finding module for package github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/test/named_subexpressions
go: finding module for package github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/test/object_cache
go: finding module for package github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/test/regress
go: finding module for package github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/test/pathology
go: finding module for package github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/test/unicode
go: finding module for package github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/test/static_mutex
go: finding module for package github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/tools/generate
go: github.com/AllenDang/giu imports
	github.com/AllenDang/cimgui-go/imgui imports
	github.com/AllenDang/cimgui-go imports
	github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/build: module github.com/AllenDang/cimgui-go@latest found (v1.3.0), but does not contain package github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/build
go: github.com/AllenDang/giu imports
	github.com/AllenDang/cimgui-go/imgui imports
	github.com/AllenDang/cimgui-go imports
	github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/example/grep: module github.com/AllenDang/cimgui-go@latest found (v1.3.0), but does not contain package github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/example/grep
go: github.com/AllenDang/giu imports
	github.com/AllenDang/cimgui-go/imgui imports
	github.com/AllenDang/cimgui-go imports
	github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/example/snippets: module github.com/AllenDang/cimgui-go@latest found (v1.3.0), but does not contain package github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/example/snippets
go: github.com/AllenDang/giu imports
	github.com/AllenDang/cimgui-go/imgui imports
	github.com/AllenDang/cimgui-go imports
	github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/example/timer: module github.com/AllenDang/cimgui-go@latest found (v1.3.0), but does not contain package github.com/AllenDang/cimgui-go/cwrappers/ImGuiColorTextEdit/vendor/regex/example/timer
go: github.com/AllenDang/giu imports
	github.com/AllenDang/cimgui-go/imgui imports

Both my packages require go1.24 in their go.mods.