-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/x509: doc: clarify package is aimed towards Web PKI support #26624
Comments
Change https://golang.org/cl/126136 mentions this issue: |
cc @FiloSottile |
Kindly paging @FiloSottile, @agl commented on the CL, please take a look. Thank you. |
I think this would also be important in terms of ensuring the package can evolve as the PKI does. However, in practice we do support custom roots, so we can't just say "WebPKI only". What about this wording?
@sleevi, any opinions? |
Yeah, I can't think of any better way to frame it, especially since you support things that are not permitted by the "Web PKI" profile (e.g. URI nameConstraints). Removing support for something the Web PKI removes support for is consistent with keeping the profiles compatible, while it's clear you don't limit support to exactly that profile. |
Change https://golang.org/cl/241118 mentions this issue: |
Change https://golang.org/cl/266541 mentions this issue: |
It's been noted before that
crypto/x509
is aimed towards only supporting the Web PKI. (See: #16858 (comment) and #24151 (comment)) However the documentation doesn't clearly state that.This means it's a bit unclear what to expect from this package.
SystemCertPool()
to return certificates for email signing?Explaining non-goals would also be helpful.
The text was updated successfully, but these errors were encountered: