Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hash/crc32: port faster CRC32-C implementation from AMD64 to AMD64P32 #16908

Closed
RaduBerinde opened this issue Aug 28, 2016 · 3 comments
Closed

hash/crc32: port faster CRC32-C implementation from AMD64 to AMD64P32 #16908

RaduBerinde opened this issue Aug 28, 2016 · 3 comments
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Performance
Milestone
Unplanned

Comments

@RaduBerinde
Copy link
Contributor

In #16107 a faster SSE4.2-based implementation for CRC32-C was introduced for AMD64. It should be adapted for AMD64P32 as well. The change should be easy, I just need to become more familiar with NaCl/amd64p32.
@quentinmit quentinmit added this to the Go1.8 milestone Sep 6, 2016
@bradfitz
Copy link
Contributor

Is this hurting you somehow? Are you using nacl/amd64p32 and this is bottleneck for your application?

@bradfitz bradfitz modified the milestones: Go1.8Maybe, Go1.8 Sep 25, 2016
@RaduBerinde
Copy link
Contributor Author

Not at all, it's just for the sake of completeness - the AMD64 optimization should work for AMD64P32 as well (with some minor modifications) and they should be on par if possible.

If we don't think it's not useful, we can definitely drop or punt it.

@rsc rsc modified the milestones: Unplanned, Go1.8Maybe Sep 30, 2016
@ALTree ALTree added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Feb 14, 2019
@agnivade
Copy link
Contributor

amd64p32 support is going to be dropped. Closing this.

@golang golang locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Performance
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
7 participants
@bradfitz @rsc @quentinmit @agnivade @ALTree @gopherbot @RaduBerinde