Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestBuildOutputToDevNull overwrites /dev/null on OpenBSD #16811

Closed
DominoTree opened this issue Aug 20, 2016 · 2 comments
Closed

cmd/go: TestBuildOutputToDevNull overwrites /dev/null on OpenBSD #16811

DominoTree opened this issue Aug 20, 2016 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-OpenBSD Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.8

Comments

@DominoTree
Copy link

DominoTree commented Aug 20, 2016 •
edited
Loading

This appears to be related to issue #12407

# go version
go version go1.7 openbsd/amd64

# ls -al /dev/null
crw-rw-rw-  1 root  wheel    2,   2 Aug 20 08:42 /dev/null
# go tool dist test -no-rebuild -v go_test:cmd/go 

##### Testing packages.
# go tool dist test -run=^go_test:cmd/go$
ok      cmd/go  167.748s

ALL TESTS PASSED (some were excluded)
# ls -al /dev/null
-rwxr-xr-x  1 root  wheel  968656 Aug 20 09:15 /dev/null

Disabling the TestBuildOutputToDevNull test in src/cmd/go/go_test.go with a runtime.GOOS check similar to the existing one seems to prevent the issue.
@bradfitz
Copy link
Contributor

We could disable the test, or we could fix the underlying problem, if there's an underlying problem to be fixed.

/cc @mdempsky

@bradfitz bradfitz added this to the Go1.8 milestone Aug 20, 2016
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. OS-OpenBSD labels Aug 20, 2016
@josharian josharian changed the title TestBuildOutputToDevNull overwrites /dev/null on OpenBSD cmd/go: TestBuildOutputToDevNull overwrites /dev/null on OpenBSD Aug 21, 2016
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 6, 2016
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/31657 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-OpenBSD Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
4 participants
@bradfitz @quentinmit @DominoTree @gopherbot