You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
#1461 switched to using multi line toml arrays in the lock file, while this improved readability it also introduced some additional diff churn.
Before:
- packages = [".","a"]
+ packages = [".","a","b"]
After:
packages = [
"."
- "a"
+ "a",
+ "b"
]
This is bad because it increases the chance of merge conflicts in the lock and decreases readability. It was also one of the reasons toml was chosen over a more mainstream format like json.
Proposal: Always add trailing commas, just like in go. This probably requires an upstream change to the toml library.
The text was updated successfully, but these errors were encountered:
#1461 switched to using multi line toml arrays in the lock file, while this improved readability it also introduced some additional diff churn.
Before:
After:
This is bad because it increases the chance of merge conflicts in the lock and decreases readability. It was also one of the reasons toml was chosen over a more mainstream format like json.
Proposal: Always add trailing commas, just like in go. This probably requires an upstream change to the toml library.
The text was updated successfully, but these errors were encountered: