From 90d9983cdd3ce600d6fcfade2b7e14df061341e2 Mon Sep 17 00:00:00 2001 From: Dmitri Shuralyov Date: Wed, 4 Jan 2023 17:18:59 -0500 Subject: [PATCH] dashboard: update js-wasm-node18 known issue and limit it to Go 1.21+ The js/wasm port is compatible with Node.js 14 but not Node.js 18, and we're in the middle of a freeze so it's too late to make changes now. Target the new builder for Go 1.21 and newer, and replace the "add builder" known issue with umbrella tracking issue for Node 18. Keep the current js-wasm builer with Node 14 as is so that the port doesn't deteriorate further in the meantime. It can be disabled for tip as soon as we have CLs to make all.bash pass with Node 18 all prepared. Fixes golang/go#57017. Updates golang/go#57614. Change-Id: I66cb4210f1e899329550162242c72de0da7aedda Reviewed-on: https://go-review.googlesource.com/c/build/+/460575 Auto-Submit: Dmitri Shuralyov Reviewed-by: Heschi Kreinick Reviewed-by: Dmitri Shuralyov TryBot-Result: Gopher Robot Run-TryBot: Dmitri Shuralyov --- dashboard/builders.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dashboard/builders.go b/dashboard/builders.go index d6628b63b6..4e7bd4187b 100644 --- a/dashboard/builders.go +++ b/dashboard/builders.go @@ -1932,9 +1932,9 @@ func init() { addBuilder(BuildConfig{ Name: "js-wasm-node18", HostType: "host-linux-amd64-js-wasm-node18", - KnownIssues: []int{57017}, + KnownIssues: []int{57614}, buildsRepo: func(repo, branch, goBranch string) bool { - b := buildRepoByDefault(repo) + b := buildRepoByDefault(repo) && atLeastGo1(goBranch, 21) switch repo { case "benchmarks", "debug", "perf", "talks", "tools", "tour", "website": // Don't test these golang.org/x repos.