Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CORS headers again #180

Merged
merged 2 commits into from
May 8, 2024
Merged

Update CORS headers again #180

merged 2 commits into from
May 8, 2024

Conversation

mattjohnsonpint
Copy link
Member

@mattjohnsonpint mattjohnsonpint commented May 8, 2024

@mattjohnsonpint mattjohnsonpint requested a review from a team as a code owner May 8, 2024 04:33
Copy link

linear bot commented May 8, 2024

HYP-1155 CORS headers are being stripped away on production endpoint

Runtime v0.6.4 was updated to emit CORS headers to resolve this issue:

This works just fine locally, but on the production endpoint there still are no CORS headers. It appears that they are being stripped away somewhere in the infra layer.

Attached test.html file reproduces the issue. It has a production endpoint and auth token hardcoded in it. Save it somewhere and just open it in Chrome. It should make a simple query and display the result. Instead it errors. Use F12 to open Chrome's developer tools console, and you'll see the CORS error:

image.png

Again, the Runtime does indeed emit CORS headers, so this is not a Runtime issue but something in the infra.

test.html

@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) May 8, 2024 04:35
@mattjohnsonpint mattjohnsonpint merged commit 92b8bc8 into main May 8, 2024
4 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/cors branch May 8, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants