-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix robot account creation issue #21310
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21310 +/- ##
==========================================
+ Coverage 45.36% 46.19% +0.82%
==========================================
Files 244 247 +3
Lines 13333 13863 +530
Branches 2719 2867 +148
==========================================
+ Hits 6049 6404 +355
- Misses 6983 7123 +140
- Partials 301 336 +35
Flags with carried forward coverage won't be shown. Click here to find out more. |
fixes goharbor#21251 Signed-off-by: wang yan <[email protected]>
414056a
to
874c5ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
End user testing in progress. we'll give you a feedback as fast as possible (i hope today) |
End user testing validated Friday. Thank you for your work on this topic. |
fixes goharbor#21251 Signed-off-by: wang yan <[email protected]>
fixes #21251
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: