Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release script #21100

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix release script #21100

merged 1 commit into from
Oct 28, 2024

Conversation

wy65701436
Copy link
Contributor

since we wil not ship the asc files since v2.12, it needs to remove the stesp to handle signatures.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

since we wil not ship the asc files since v2.12, it needs to remove the stesp to handle signatures.

Signed-off-by: wang yan <[email protected]>
@wy65701436 wy65701436 requested a review from a team as a code owner October 28, 2024 06:38
@wy65701436 wy65701436 added the release-note/infra Infra related changes e.g. release, test, ship etc... label Oct 28, 2024
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stonezdj stonezdj enabled auto-merge (squash) October 28, 2024 06:42
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.06%. Comparing base (c8c11b4) to head (c44a812).
Report is 309 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #21100       +/-   ##
===========================================
+ Coverage   45.36%   66.06%   +20.69%     
===========================================
  Files         244     1049      +805     
  Lines       13333   114649   +101316     
  Branches     2719     2867      +148     
===========================================
+ Hits         6049    75739    +69690     
- Misses       6983    34768    +27785     
- Partials      301     4142     +3841     
Flag Coverage Δ
unittests 66.06% <ø> (+20.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1288 files with indirect coverage changes

@stonezdj stonezdj merged commit 91082af into goharbor:main Oct 28, 2024
13 of 14 checks passed
wy65701436 added a commit to wy65701436/harbor that referenced this pull request Oct 29, 2024
we will not ship the asc files since v2.12, it needs to remove the steps to handle signatures in the release script.

Signed-off-by: wang yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants