Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add generate sbom object utility #20097

Merged
merged 8 commits into from
Mar 12, 2024
Merged

add generate sbom object utility #20097

merged 8 commits into from
Mar 12, 2024

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Mar 6, 2024 •
edited
Loading

Leverage the go-containerregistry to generate the oci object for sbom and add it as an accessory of the subject artifact.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@wy65701436 wy65701436 requested a review from a team as a code owner March 6, 2024 08:59
@wy65701436
add generate sbom object utility
b7179ed 
Leverage the go-containerregistry to generate the oci object for sbom and add it as an accessory of the subject artifact.

Signed-off-by: wang yan <[email protected]>
@wy65701436 wy65701436 assigned zyyw and unassigned OrlinVasilev Mar 6, 2024
@wy65701436 wy65701436 added the release-note/new-feature New Harbor Feature label Mar 6, 2024
@wy65701436 wy65701436 force-pushed the sbom-oci branch 2 times, most recently from f6ec8df to ec1845c Compare March 6, 2024 10:33
@wy65701436
remove vendor
7eb2870 
Signed-off-by: wang yan <[email protected]>
zyyw
zyyw reviewed Mar 7, 2024
View reviewed changes
@wy65701436 wy65701436 force-pushed the sbom-oci branch 3 times, most recently from 6fe0aa8 to 2d3acd8 Compare March 7, 2024 06:14
@wy65701436
resolve comments
f05797a 
Signed-off-by: wang yan <[email protected]>
stonezdj
stonezdj reviewed Mar 8, 2024
View reviewed changes
@wy65701436
resolve comments
46cf773 
Signed-off-by: wang yan <[email protected]>
@wy65701436
remove the todo comments
05cf91a 
Signed-off-by: wang yan <[email protected]>
@wy65701436 wy65701436 merged commit dbe9790 into goharbor:main Mar 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonezdj stonezdj stonezdj approved these changes

@zyyw zyyw zyyw approved these changes

Assignees

@stonezdj stonezdj

@zyyw zyyw

@chlins chlins

Labels
release-note/new-feature New Harbor Feature target/2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wy65701436 @stonezdj @zyyw @OrlinVasilev @chlins