From 53b05302f22406f483d6904a548b0ef8fe5222dd Mon Sep 17 00:00:00 2001 From: Juan Calderon-Perez Date: Sun, 3 Mar 2024 22:45:38 -0500 Subject: [PATCH] Do not run timing sensitive tests in parallel --- internal/memory/memory_test.go | 31 ++++++++++++++++--------------- middleware/logger/logger_test.go | 1 - middleware/proxy/proxy_test.go | 6 +++--- 3 files changed, 19 insertions(+), 19 deletions(-) diff --git a/internal/memory/memory_test.go b/internal/memory/memory_test.go index 76a751b78d..1dfe89e5ee 100644 --- a/internal/memory/memory_test.go +++ b/internal/memory/memory_test.go @@ -9,9 +9,7 @@ import ( ) // go test -run Test_Memory -v -race - func Test_Memory(t *testing.T) { - t.Parallel() store := New() var ( key = "john" @@ -19,38 +17,41 @@ func Test_Memory(t *testing.T) { exp = 1 * time.Second ) + // Set key with value store.Set(key, val, 0) - store.Set(key, val, 0) - result := store.Get(key) require.Equal(t, val, result) + // Get non-existing key result = store.Get("empty") - require.Equal(t, nil, result) + require.Nil(t, result) + // Set key with value and ttl store.Set(key, val, exp) time.Sleep(1100 * time.Millisecond) - result = store.Get(key) - require.Equal(t, nil, result) + require.Nil(t, result) // TODO: This is failing + // Set key with value and no expiration store.Set(key, val, 0) result = store.Get(key) require.Equal(t, val, result) + // Delete key store.Delete(key) result = store.Get(key) - require.Equal(t, nil, result) + require.Nil(t, result) - store.Set("john", val, 0) - store.Set("doe", val, 0) + // Reset all keys + store.Set("john-reset", val, 0) + store.Set("doe-reset", val, 0) store.Reset() - result = store.Get("john") - require.Equal(t, nil, result) - - result = store.Get("doe") - require.Equal(t, nil, result) + // Check if all keys are deleted + result = store.Get("john-reset") + require.Nil(t, result) + result = store.Get("doe-reset") + require.Nil(t, result) } // go test -v -run=^$ -bench=Benchmark_Memory -benchmem -count=4 diff --git a/middleware/logger/logger_test.go b/middleware/logger/logger_test.go index b385ea69e0..f24668e19a 100644 --- a/middleware/logger/logger_test.go +++ b/middleware/logger/logger_test.go @@ -230,7 +230,6 @@ func getLatencyTimeUnits() []struct { // go test -run Test_Logger_WithLatency func Test_Logger_WithLatency(t *testing.T) { - t.Parallel() buff := bytebufferpool.Get() defer bytebufferpool.Put(buff) app := fiber.New() diff --git a/middleware/proxy/proxy_test.go b/middleware/proxy/proxy_test.go index 089b33b3ef..dd24a6c03a 100644 --- a/middleware/proxy/proxy_test.go +++ b/middleware/proxy/proxy_test.go @@ -487,11 +487,11 @@ func Test_Proxy_DoTimeout_Timeout(t *testing.T) { app := fiber.New() app.Get("/test", func(c fiber.Ctx) error { - return DoTimeout(c, "http://"+addr, time.Second) + return DoTimeout(c, "http://"+addr, 1*time.Second) }) - _, err1 := app.Test(httptest.NewRequest(fiber.MethodGet, "/test", nil), int((1*time.Second)/time.Millisecond)) - require.Equal(t, errors.New("test: timeout error 1000ms"), err1) + _, err1 := app.Test(httptest.NewRequest(fiber.MethodGet, "/test", nil), int((1*time.Second)/(10*time.Millisecond))) + require.Equal(t, errors.New("test: timeout error 100ms"), err1) } // go test -race -run Test_Proxy_DoDeadline_RestoreOriginalURL