Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorldEnvironment glow has no effect in EditorPlugin #83940

Open
jinyangcruise opened this issue Oct 25, 2023 · 5 comments
Open

WorldEnvironment glow has no effect in EditorPlugin #83940

jinyangcruise opened this issue Oct 25, 2023 · 5 comments

Comments

@jinyangcruise
Copy link

Godot version

v4.2.beta2.official [f8818f8]

System information

Vulkan API 1.3.205 - Forward+ - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 3060 Ti

Issue description

WorldEnvironment glow has no effect in EditorPlugin when addon activated.

屏幕截图 2023-10-25 213224 屏幕截图 2023-10-25 213258

Steps to reproduce

NA

Minimal reproduction project

test_worldenvironment_in_editorplugin.zip

@clayjohn
Copy link
Member

Does your Viewport have 2D_HDR enabled?

@jinyangcruise
Copy link
Author

jinyangcruise commented Oct 25, 2023

Does your Viewport have 2D_HDR enabled?

No, but it's same if 2D HDR enabled.

image

@Calinou
Copy link
Member

Calinou commented Oct 25, 2023

Is the environment background mode set to Canvas? Remember that the editor renders in its own viewport, so you likely need to assign an environment to it if you want to make the editor itself glow.

@jinyangcruise
Copy link
Author

Is the environment background mode set to Canvas? Remember that the editor renders in its own viewport, so you likely need to assign an environment to it if you want to make the editor itself glow.

I think so. There is an environment node in the main scene and its background mode is set to Canvas.

@Calinou
Copy link
Member

Calinou commented Oct 26, 2023

I think so. There is an environment node in the main scene and its background mode is set to Canvas.

This only affects the project, not the editor. WorldEnvironment nodes in the editor will
never affect the editor itself by design (outside of the 2D/3D viewport, that is). This occurred in the past due to bugs and it's not exactly behavior that should happen by default again 🙂

See #72343. You can try using RenderingServer.viewport_set_environment_mode() on the editor root viewport RID with the value VIEWPORT_ENVIRONMENT_ENABLED, but this will affect the entire editor rendering and not just your editor plugin. I think the better solution here is to use a Viewport in your edition plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants