Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot errors when generating LOD for a too big GLB file #80431

Closed
ghost opened this issue Aug 8, 2023 · 5 comments
Closed

Godot errors when generating LOD for a too big GLB file #80431

ghost opened this issue Aug 8, 2023 · 5 comments

Comments

@ghost
Copy link

ghost commented Aug 8, 2023

Godot version

4.1

System information

Godot v4.1.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 SUPER (NVIDIA; 31.0.15.3640) - Intel(R) Core(TM) i7-10700KF CPU @ 3.80GHz (16 Threads)

Issue description

When loading this GLB file, Godot crashes without any error message. (ZIP-ed for file size reasons.)

When loading Godot in debug mode, the following error is issued:

Vulkan API 1.3.242 - Forward+ - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 2060 SUPER

ERROR: Condition "!_ptrnew" is true. Returning: ERR_OUT_OF_MEMORY
   at: resize (./core/templates/cowdata.h:297)

However, according to the resource monitor Godot doesn't consume anywhere near the 64 GB of RAM in this machine:

image

The GLB has 2.7M vertices, which loads without problems in other 3D engines.

Steps to reproduce

Drag the attached GLB file into any Godot project.

Minimal reproduction project

None necessary, but included here.

@fire
Copy link
Member

fire commented Aug 8, 2023

I haven't inspected the file yet, but when the byte count exceeds the 32 bit length limit godot fails to load the binary.

@ghost
Copy link
Author

ghost commented Aug 9, 2023

The file is ~100 MB, so that shouldn't be the case .

@aaronfranke
Copy link
Member

The crash is in the LOD generator. I opened a PR to replace the crash with a warning: #80467

@ghost
Copy link
Author

ghost commented Aug 10, 2023

Thank you @aaronfranke !

@akien-mga akien-mga changed the title Godot crash on GLB import Godot errors when generating LOD for a too big GLB file Sep 21, 2023
@fire
Copy link
Member

fire commented Oct 2, 2023

Fixed by: #80467

@fire fire closed this as completed Oct 2, 2023
@akien-mga akien-mga added this to the 4.2 milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants