Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing into Find text box in Find/Replace loses selection and searches file for the text instead #47450

Closed
chucklepie opened this issue Mar 29, 2021 · 2 comments · Fixed by #47625

Comments

@chucklepie
Copy link

chucklepie commented Mar 29, 2021

Godot version:
3.2.3

OS/device including version:
Linux

Issue description:
Typing into the find part of the Find/Replace option loses your selection and searches entire file for the text.

When you are only searching for text then highlighting the first occurrence is fine, but when you want to search/replace and Selection Only is highlighted this behaviour is wrong.

Steps to reproduce:

  1. Select some lines of text
  2. Press CTRL-R (selection only should be ticked)
  3. Type something into the top 'find' box
  4. Your selection is gone and the IDE jumps to the first occurrence

What you have to do is a sequence that isn't 'normal' by remembering to bring up the search bar, entering the find text then selecting the text.

I expect this is because the 'find' and 'find/replace' use the same code.

Minimal reproduction project:

@Calinou
Copy link
Member

Calinou commented Mar 29, 2021

cc @Paulb23

@Paulb23
Copy link
Member

Paulb23 commented Apr 3, 2021

Probably need to skip this if selection only is ticked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants