Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appending array to itself causes crash without any errors #28089

Closed
aomimezura opened this issue Apr 16, 2019 · 5 comments · Fixed by #28217
Closed

Appending array to itself causes crash without any errors #28089

aomimezura opened this issue Apr 16, 2019 · 5 comments · Fixed by #28217
Assignees
Milestone

Comments

@aomimezura
Copy link

Godot version:

3.1

OS/device including version:

Ubuntu 14.04

Issue description:

If you append an array to itself, the game crashes without showing any errors or printing any text before the append is done making debugging the crash extremely difficult.

Steps to reproduce:
Create array. Next, print something. Then append the array to itself. Run. You will see the game crash WITHOUT the print working and you get no error messages.
SelfReferenceBug.zip

Minimal reproduction project:

@Zireael07
Copy link
Contributor

I believe it's a dupe of an existing issue, but I can't find it atm.

@qarmin
Copy link
Contributor

qarmin commented Apr 16, 2019

This happens because Variant::operator String call self recursively.
Zrzut ekranu z 2019-04-16 20-03-16

@aomimezura
Copy link
Author

I understand WHY it happens, just not why it doesn't tell you it's an error. It was a difficult bug to track down in my code because of it.

@groud
Copy link
Member

groud commented Apr 17, 2019

I understand WHY it happens, just not why it doesn't tell you it's an error.

I think @qarmin's message was not addressed to you specifically, but to anyone who wanted to work on this issue.

But yeah, the engine should raise an error.

@akien-mga akien-mga added this to the 3.2 milestone Apr 17, 2019
@akien-mga
Copy link
Member

Related to #1289.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants