Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding different material roughness parameters for easy testing to 3d/material_tests #897

Closed
armanpapikyan opened this issue Mar 28, 2023 · 3 comments

Comments

@armanpapikyan
Copy link

The material tests scene demo has a range of materials currently on display for the demo, but it lacks a grid of abstract materials with specific increments for testing purposes of PBR.

While iterating on SSR I set up this grid that has both dielectrics and metals, and varying roughness value from 1.0 on the left to 0.0 on the right by a 0.1 step (simply duplicating the materials and setting the metal and roughness parameters on it).

image

No changes done to the demo itself, the new platform is outside of the camera frustum when going through the materials in the demo.
image

I already have this setup locally and if this can be useful I can open a PR.

@Calinou
Copy link
Member

Calinou commented Mar 28, 2023

#809 has a setup with all roughness and metallic levels, but I think it makes sense to add this to the Material Testers demo as well.

Feel free to open a pull request for this 🙂

No changes done to the demo itself, the new platform is outside of the camera frustum when going through the materials in the demo.

It makes sense to set visible = false on those nodes in _ready(), so that you can see them in the editor but not in the running project (to improve performance on low-end systems).

@armanpapikyan
Copy link
Author

visible = false added on a separate dedicated script, didn't want to introduce unncessary dependencies on the demo test script.

PR created #899

@Calinou
Copy link
Member

Calinou commented Mar 30, 2023

@Calinou Calinou closed this as completed Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants