Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(splito-api-binding): ensure latest splits are saved and add tests #15

Merged
merged 3 commits into from
Dec 18, 2019

Conversation

celiawaggoner
Copy link
Contributor

modify behavior in getSplits so that we don't save splits that have been archived after the initial request.

For Splits you'll receive again the full split object for each split that received changes since the last fetch. It's safe to assume that you can just overwrite the representation you had for that specific split, being the name of the split a unique id.

In case of the edge case, you'll hit it with -1 and again with a different value. The second request can come either empty (because you had up to date information) or with the updates that were not propagated yet.

lib/splitio-api-binding.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants