Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SizeControl components to use the new reusable component #1041

Closed
2 of 3 tasks
Tracked by #2077
richtabor opened this issue Oct 21, 2019 · 1 comment · Fixed by #2293
Closed
2 of 3 tasks
Tracked by #2077

Update SizeControl components to use the new reusable component #1041

richtabor opened this issue Oct 21, 2019 · 1 comment · Fixed by #2293
Assignees
Labels
Good First Issue A great place to start if you're new to contributing [Priority] Low This issue/pull request is not immediate [Type] Maintenance Minor file cleanup and organization tasks

Comments

@richtabor
Copy link
Contributor

richtabor commented Oct 21, 2019

We should attempt updating existing SizeControl components to use the upcoming component @jrtashjian is working on adding to replace the ButtonGroup type components we are using in the Posts and Carousel blocks.

There's some logic in how some of the SizeControl components display per different alignment settings (wide or full). We need to decide if we want to maintain that logic, or bake in a way to pass that logic through the new component.

We can remove the SizeControl component once it's been replaced throughout the blocks:

Carousel and Masonry refactors should be handled in respective refactor issues

  • Carousel
  • Masonry
  • Stacked
@jrtashjian jrtashjian self-assigned this Nov 22, 2019
@jrtashjian jrtashjian added [Block] Carousel Gallery [Type] Enhancement Something new that adds functionality labels Nov 22, 2019
@github-actions github-actions bot removed UX labels Feb 9, 2020
@richtabor richtabor added [Type] Maintenance Minor file cleanup and organization tasks and removed [Block] Masonry Gallery [Type] Enhancement Something new that adds functionality labels Feb 10, 2020
@jrtashjian jrtashjian added the [Priority] Low This issue/pull request is not immediate label Jul 16, 2020
@jrtashjian
Copy link
Member

This is still a valid "issue". To clarify what needs to happen here: we are replacing the SizeControl component with the new OptionSelectorControl component used in the Features, Food and Drinks, Posts, Pricing Table, Row, and Services blocks.

The three blocks listed in the issue description still require updating but the Collage and Offset gallery blocks already use this component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue A great place to start if you're new to contributing [Priority] Low This issue/pull request is not immediate [Type] Maintenance Minor file cleanup and organization tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants