Buffalo - Heroku Buildpack

[bscott]

Creating this issue just as a reminder to test the Heroku Go buildpack with Buffalo.

[paganotoni]

@bscott this one depends on #134 (given heroku buildpack supports Glide) and adding a Procfile to the generated app, should we create an issue to add the Procfile to the new generated app ?

[bscott]

@apaganobeleno I think we should but your right as Heroku does only support Godeps atm.

[paganotoni]

@bscott I think it supports Glide as well, yes, just confirmed:

https://github.com/heroku/heroku-buildpack-go/blob/master/README.md

[bscott]

@apaganobeleno Nice

[philipithomas]

It would be nice to document how to run grift commands as cron jobs on heroku too

[paganotoni]

@bscott @markbates i can spend some time working on this one (i need it), do you guys think its pertinent to work on this one now ?

[markbates]

@apaganobeleno if you need it, then it's pertinent. :)

[paganotoni]

@markbates awesome, i'll keep you posted on this one, thanks!

[paganotoni]

@markbates @bscott i built a very basic buildpack for buffalo, it compiles the app successfully but at the end i'm having the same issue i've mentioned over slack.

When running the app it says:

panic: could not locate box "../public/assets"

Any idea what could i be missing ?

[paganotoni]

This is the app i'm using with the buildpack -> https://github.com/apaganobeleno/app

[freeformz]

I am the maintainer of the heroku go buildpack, so If you have any needs that aren't met by it, then I am interested in fixing it in the buildpack. I have considered directly adding support for buffalo in the buildpack, but it hasn't reached the top of my queue yet.

[paganotoni]

hey @freeformz, thanks for reaching out, and thanks for the heroku-go build-pack! i've mostly copy/pasted the code from it and heroku-nodejs build-pack.

We're having an issue after building the app where it doesn't find some embedded assets, IDK if its something that i'm doing wrong with the env variables or some dependency that go.rice has and i have not included in the build-pack, i'll continue looking into this but anyways any help you could give us with this is appreciated.

[markbates]

@apaganobeleno it sounds like the same issue from. Try creating the missing folder in the build pack.

[markbates]

That folder isn't checked in, it's in the .gitignore because webpack should build it.

[paganotoni]

@markbates Yes, right, its ignored by default which is ok, i just modified the build-pack to create /public/assets but it still doesn't work :(.

[freeformz]

Assuming the git push heroku master workflow of a gobuffalo project that has a glide.yaml (or other vendor tool's file(s)) checked in, what is the most reliable way to determine that the code being received on the other side is a gobuffalo project? I'm thinking of sniffing for actions/app.go and looking for an import of github.com/gobuffalo/buffalo. Does that sound reasonable and likely to be true?

[paganotoni]

@freeformz i think by checking the existence of the buffalo.dev.yml should be enough.
Unless @markbates is planning to remove that file from the generated project :).

[freeformz]

@apaganobeleno I can't find that file anywhere in my test gobuffalo project created with v0.7.3.

[markbates]

It's a hidden dot file '.buffalo.dev.yml'

[freeformz]

hah. So it is!

[markbates]

I wonder if we still need this ticket now that we have docker images. https://blog.gobuffalo.io/deploying-buffalo-to-heroku-with-docker-adafa4afdd6f It's so easy to deploy to heroku using the docker images it's not even funny. Thoughts on closing this?

[paganotoni]

@markbates we should close it now that you've provided a concise deployment strategy and steps, this ticket is more about that than using heroku build-packs (which i love).

[markbates]

Cool. I'm going to close this.