Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Default js and css file when webpack is skipped #116

Closed
fooflare opened this issue Jan 12, 2017 · 3 comments · Fixed by #117
Closed

Default js and css file when webpack is skipped #116

fooflare opened this issue Jan 12, 2017 · 3 comments · Fixed by #117

Comments

@fooflare
Copy link
Contributor

I have created a branch in my fork with these 2 default files when webpack is skipped during new project process. I think this is a good idea because in the template they are linked in any case. I added some style to the default page to look a bit similar to the webpack one (no responsive nor font-awesome), just to avoid the big image and the text at the end of the page :). Have a look at it and if you agree I can PR:
https://github.com/fooflare/buffalo/commit/a4c1cf300d937ace42261d2f4e1a65a2a4f479f0

And now, just one question. Why is the logo image generated in assets and in public/assets? I understand that assets folder is for css and js source files, but I don't get why the logo is saved there too. I ask this because in the case of not using webpack, I think this folder could be omitted.

@markbates
Copy link
Member

I like it. Please submit a PR.

The logo should only be generated in assets if using webpack, and public/assets if not. If it's putting it in both places during app generation, it's a bug.

Webpack copies everything over from the assets to the public/assets folder during compilation.

@fooflare
Copy link
Contributor Author

In the case of webpack generation, it is saved just in assets as you say, but in the case you skip webpack, it is saved in both folders, one in app_generators and the other in webpack. Then I can remove the one in the app_generators if you want.

@markbates
Copy link
Member

That would be great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants