From 304cfd62b978352c62fbc74dabc975971ca696fb Mon Sep 17 00:00:00 2001
From: Simmo Saan <simmo.saan@gmail.com>
Date: Thu, 17 Feb 2022 16:58:26 +0200
Subject: [PATCH] Add semgrep rule for Fun.id

---
 .semgrep/fun.yml    | 6 ++++++
 src/cdomains/exp.ml | 2 +-
 src/cdomains/mHP.ml | 2 +-
 3 files changed, 8 insertions(+), 2 deletions(-)
 create mode 100644 .semgrep/fun.yml

diff --git a/.semgrep/fun.yml b/.semgrep/fun.yml
new file mode 100644
index 0000000000..209e601fdc
--- /dev/null
+++ b/.semgrep/fun.yml
@@ -0,0 +1,6 @@
+rules:
+  - id: fun-id
+    pattern: fun $X -> $X
+    message: use Fun.id instead
+    languages: [ocaml]
+    severity: WARNING
diff --git a/src/cdomains/exp.ml b/src/cdomains/exp.ml
index 7e1c762481..1e662865b3 100644
--- a/src/cdomains/exp.ml
+++ b/src/cdomains/exp.ml
@@ -192,7 +192,7 @@ struct
     let rec separate_fields_index o =
       match o with
       | NoOffset -> None
-      | Index (ie,o) -> Some ((fun x -> x),ie,o)
+      | Index (ie,o) -> Some (Fun.id,ie,o)
       | Field (f,o) ->
         match separate_fields_index o with
         | Some (osf, ie,o) -> Some ((fun o -> Field (f,o)), ie, o)
diff --git a/src/cdomains/mHP.ml b/src/cdomains/mHP.ml
index 3d95600292..86e7676097 100644
--- a/src/cdomains/mHP.ml
+++ b/src/cdomains/mHP.ml
@@ -23,7 +23,7 @@ let pretty () {tid; created; must_joined} =
     else
       Some (Pretty.dprintf "must_joined=%a" ConcDomain.ThreadSet.pretty must_joined)
   in
-  let docs = List.filter_map (fun doc -> doc) [tid_doc; created_doc; must_joined_doc] in
+  let docs = List.filter_map Fun.id [tid_doc; created_doc; must_joined_doc] in
   Pretty.dprintf "{%a}" (Pretty.d_list "; " Pretty.insert) docs
 
 include Printable.SimplePretty (