Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure file transforms without sourcemaps don't grow an invalid map after first run #39

Merged
merged 1 commit into from
Mar 20, 2015

Conversation

evs-chris
Copy link
Contributor

I have a file transform that just returns a string, but after a successful initial build, it always fails trying to read the cached map file. This corrects that by not setting mappath unless the transform returns an object.

I'm not sure about the unrelated noise in lib, but I'm guessing it's a dependency update causing it?

Rich-Harris added a commit that referenced this pull request Mar 20, 2015
Make sure file transforms without sourcemaps don't grow an invalid map after first run
@Rich-Harris Rich-Harris merged commit a55e724 into gobblejs:master Mar 20, 2015
@Rich-Harris
Copy link
Contributor

Awesome, thanks - I'd noticed this once or twice but hadn't had a chance to look into it. I had to add simulateChange in the test in order to trigger a rebuild on OS X... writing files programmatically doesn't activate the watcher for whatever reason. Hopefully that didn't break anything else.

Released in 0.7.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants