Missing mirror URL on project dashboard

[somera]

Description

Since I upgraded to 1.21.0 I see more and more mirrors with no Mirror URL

The sync for this mirror is working.

In PostgreSQL I see the URL

I checked ~200 projects. In 24 the mirror url is not visible. some days ago I deleted one mirror and added it again and I saw the mirror url. But today I can't see it in project dashboard.

Gitea Version

1.21.0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.43.0

Operating System

Ubuntu 20.04.x

How are you running Gitea?

gitea-1.21.0-linux-amd64

Database

PostgreSQL

[lunny]

Could you find any error logs?

[somera]

@lunny. No.

In browser I see this

[lunny]

I think it maybe a translation problem. Could you try English?

[somera]

As I wrote. No -> I can't see any errors in the gitea logs.

The screenshot which I posted was just from the browser. This was probably confusing.

[lunny]

Yes. To confirm my guess. Could you try to switch English from the footer right corner and take a look again?

[somera]

I try this later. I'm upgrading now to PostgreSQL 16 and Ubuntu 22.04.

[somera]

I did it. Same problem

[somera]

I found at the moment 44 projects with this issue. But I have no time to check all mirrors.

[somera]

~80 mirrors now affected.

[somera]

@lunny no changes here with 1.21.1

[somera]

@lunny when I do this

[Mo Nov 27][19:23:44][xxx]@[xxx]:[~]$ curl http://xxx/git/api/v1/repos/skeeto/Spacefront | jq | grep original
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2111    0  2111    0     0   223k      0 --:--:-- --:--:-- --:--:--  229k
  "original_url": "https://github.com/skeeto/Spacefront.git",

than I see the original_url. Looks good.

I restarted my memcached. But there was no change.

[somera]

@lunny any updates here? The problem makes it a little difficult for me to work with Gitea.

[somera]

@lunny I found the problem. ~17% mirrors are affected on my gitea instance. The problem is, that in the mirrors table the remote_address column is empty. I can fix it by setting the column. But there is an bug, cause I migrated new mirrors and some days later the url was empty.

The question is: why is this empty?

[somera]

After my fix in the DB three days ago nothing changes. It's looks good.

@lunny if you think there is nothig to fix, than this issue can be closed.

[yp05327]

Maybe related to #26952

[lunny]

After my fix in the DB three days ago nothing changes. It's looks good.

@lunny if you think there is nothig to fix, than this issue can be closed.

Let's leave the issue open since it's possible a bug. And how did you do the workaround?

[yp05327]

It seems that this issue is caused by the migration, as remote_address column is empty but original_url is not.

[somera]

Let's leave the issue open since it's possible a bug. And how did you do the workaround?

I set remote_address to the same value like original_url. Before I did this, I compared all te mirrors where remote_address was set.

[lunny]

Let's leave the issue open since it's possible a bug. And how did you do the workaround?

I set remote_address to the same value like original_url. Before I did this, I compared all te mirrors where remote_address was set.

After you fix it manually, does any mirrors remote_address become empty?

[wxiaoguang]

There are not only one issue report for the RemoteAddress problem (eg: #29132)

I think " Add RemoteAddress to mirrors #26952 " is not robust enough.

[somera]

After you fix it manually, does any mirrors remote_address become empty?

No. It works fine.

[lunny]

There are not only one issue report for the RemoteAddress problem (eg: #29132)

I think " Add RemoteAddress to mirrors #26952 " is not robust enough.

Yes, but maybe we can close this one or keep this open for some future refactor PRs about that?

[wxiaoguang]

Yes, but maybe we can close this one or keep this open for some future refactor PRs about that?

But I just hope there could be a PR fixing the robust problem. It is critical and stops users from upgrading.

[richex-cn]

Same issue when I migrate to new version. I have manually fixed it using the following SQL:

UPDATE mirror m SET remote_address = (SELECT r.original_url FROM repository r WHERE r.id = m.repo_id);

[somera]

I didn't see this issue again after my manual fix in 2023.

[wxiaoguang]

There are not only one issue report for the RemoteAddress problem (eg: #29132)

I think " Add RemoteAddress to mirrors #26952 " is not robust enough.

Yup, it is a bug of #26952 (the migration), so after the version upgrade, it's unlikely to happen again.