Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks when open/close issue #26106

Open
yp05327 opened this issue Jul 25, 2023 · 0 comments
Open

Add checks when open/close issue #26106

yp05327 opened this issue Jul 25, 2023 · 0 comments
Labels

Comments

@yp05327
Copy link
Contributor

yp05327 commented Jul 25, 2023

Description

We have no checks for whether we can open or close an issue which causes some bugs like #25883.
I notice that #25883 is not enough to fix this problem, as we also have api of changing issue status
and not only merged PRs but also PRs with deleted branch.

You can see that I reopened this PR but the branch is already deleted here:
https://try.gitea.io/yp05327/testrepo/pulls/7
image

Normally we can not open it in the PR view page, but you can do it in the issue list(select one, then click open/close button)
https://try.gitea.io/yp05327/testrepo/pulls/9
image

If you created a new branch with the same branch name, the Commits and Files Changed will be broken:
https://try.gitea.io/yp05327/testrepo/pulls/8
image
But you can access Files Changed page, and get a strange block here:
image

Maybe we should discuss a summary about when we should not open/close an issue at first, and then fix it.

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant