Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a test for the 'database is locked' and 'database table is locked' error #2009

Closed
typeless opened this issue Jun 19, 2017 · 5 comments
Closed

Create a test for the 'database is locked' and 'database table is locked' error #2009

typeless opened this issue Jun 19, 2017 · 5 comments
Labels
type/testing
Milestone
1.7.0

Comments

@typeless
Copy link
Contributor

I tried to re-use the 'NewIssue' integration test for the purpose, creating a test with two goroutines each looping the test 100 times. But it takes quite long time to run and not that reliable given the number of iterations are not that high.

Any thoughts?
@typeless typeless changed the title Create a test for triggering the 'database is locked' and 'database table is locked' error Create a test for the 'database is locked' and 'database table is locked' error Jun 19, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Jun 19, 2017

This is easy actually, just make all tests run in parallel ;)

@typeless
Copy link
Contributor Author

@bkcsoft Would it not affect the CI running time? I suppose the Drone CI server doesn't provide too many cores for free instances.

Anyway I will still submit the PR for troubleshooting the database locking issue. And we can discuss whether to add it to the 'official' test suite later.

@bkcsoft
Copy link
Member

bkcsoft commented Jun 19, 2017

Running the test in parallel would make it run faster, if we allow to run multiple processes 😉

@lunny lunny added this to the 1.x.x milestone Jun 23, 2017
@lunny
Copy link
Member

lunny commented Jun 23, 2017

testing for #2040

@lunny lunny modified the milestones: 1.x.x, 1.7.0 Oct 23, 2018
@lunny
Copy link
Member

lunny commented Oct 24, 2018

Closed by #5144 since the test-sqlite has been reenabled on that PR.

@lunny lunny closed this as completed Oct 24, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/testing
Projects
None yet
Milestone
1.7.0
Development

No branches or pull requests
3 participants
@lunny @typeless @bkcsoft