Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PGP-Key: Problem with leading zero #16701

Closed
1 task done
Snck3rs opened this issue Aug 16, 2021 · 9 comments
Closed
1 task done

PGP-Key: Problem with leading zero #16701

Snck3rs opened this issue Aug 16, 2021 · 9 comments
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail type/bug

Comments

@Snck3rs
Copy link

Snck3rs commented Aug 16, 2021

Hello Guys,

i ran into a problem with PGP-Keys. After i've added my Key to Gitea and made my first signed commit it says that theres no matching key. I compared the key showed in the commit with my configured key and found out, that the leading zero of my key is missing in the commit-view.

Maybe there's a bug related to leading zeros in PGP-Keys?

Account -> PGP-Keys

2021-08-16_10-00

Commit

2021-08-16_09-59

Installation Data

  • Gitea version: 1.14.4 and 1.15.0+RC3

  • Database:

    • MySQL
@zeripath
Copy link
Contributor

On 1.15.0-rc3 the key tells you which identities it matches - that is the email addresses that were activated when the key was installed - does the commit you are trying to verify have match one of those identities?

On 1.15.0-rc3 you can verify the key to match any of your user's activated email addresses. Have you verified the key?

@zeripath zeripath added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Aug 16, 2021
@zeripath
Copy link
Contributor

Also, have you tried re-adding the key? If the key was added a long time ago - it's possible that it was affected by a previous bug that has been fixed.

If this genuinely is a bug it would be helpful to see an example of a commit on try.gitea.io with the key. If you'd prefer to not to make that public contact me on discord directly with details so that I can replicate.

@Snck3rs
Copy link
Author

Snck3rs commented Aug 16, 2021

@zeripath thank you so much!

On 1.15.0-rc3 the key tells you which identities it matches - that is the email addresses that were activated when the key was installed - does the commit you are trying to verify have match one of those identities?

the keys mail adresses where already activated before adding the key. so i've thought it would be enough just to add the key.

On 1.15.0-rc3 you can verify the key to match any of your user's activated email addresses. Have you verified the key?

That's it! After verifying the key everythink works like expected. Is this a new feature or have i just been blind in 1.14.4?

@Snck3rs
Copy link
Author

Snck3rs commented Aug 16, 2021

Also, have you tried re-adding the key? If the key was added a long time ago - it's possible that it was affected by a previous bug that has been fixed.

It was a new key added in 1.14.4, but i remembered the bugfix for this old problem so i've guessed it could be the same reason in my case too.

If this genuinely is a bug it would be helpful to see an example of a commit on try.gitea.io with the key. If you'd prefer to not to make that public contact me on discord directly with details so that I can replicate.

@Snck3rs
Copy link
Author

Snck3rs commented Aug 16, 2021

b.t.w. i've created a small script for download and updating gitea a long time ago. Maybe it could be useful for lazy bones like me ;-)

https://entwicklung.hq.tosit.de/Snck3rs/Gitea-Updater

@zeripath
Copy link
Contributor

@zeripath thank you so much!

On 1.15.0-rc3 the key tells you which identities it matches - that is the email addresses that were activated when the key was installed - does the commit you are trying to verify have match one of those identities?

the keys mail adresses where already activated before adding the key. so i've thought it would be enough just to add the key.

It should be - I guess the key has to have the email address in it too.

On 1.15.0-rc3 you can verify the key to match any of your user's activated email addresses. Have you verified the key?

That's it! After verifying the key everythink works like expected. Is this a new feature or have i just been blind in 1.14.4?

Yes - new feature in 1.15 - see #14054

@Snck3rs
Copy link
Author

Snck3rs commented Aug 16, 2021

@zeripath thank you so much!

On 1.15.0-rc3 the key tells you which identities it matches - that is the email addresses that were activated when the key was installed - does the commit you are trying to verify have match one of those identities?

the keys mail adresses where already activated before adding the key. so i've thought it would be enough just to add the key.

It should be - I guess the key has to have the email address in it too.

that's strange. my key should have the mail address in it. plus a second identity with another email address. Both mail addresses have been configured in my gitea account before adding the key itself. if you want to dig deeper into that case i could provide you the informations you need.

On 1.15.0-rc3 you can verify the key to match any of your user's activated email addresses. Have you verified the key?

That's it! After verifying the key everythink works like expected. Is this a new feature or have i just been blind in 1.14.4?

Yes - new feature in 1.15 - see #14054

@zeripath
Copy link
Contributor

I think it would be useful to see an example commit that isn't verifying on try or elsewhere.

@zeripath
Copy link
Contributor

I think this is fixed. please reopen if not.

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail type/bug
Projects
None yet
Development

No branches or pull requests

3 participants