Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user-provided variables (branch feature/user_vars) -- vote for inclusion in master #8

Closed
xorpaul opened this issue Aug 12, 2016 · 2 comments

Comments

@xorpaul
Copy link

xorpaul commented Aug 12, 2016

Hello there,

do you plan to also migrate the feature branch user_vars from code.google.com to this repository?

I'm currently depending on this feature branch for a project.

A merge of the feature branch to master would be even better! :)

@speter
Copy link
Contributor

speter commented Aug 12, 2016

tl;dr: feature/user_vars now available. People who need this please "thumbs-up" this comment to vote to have it merged into master.

Full comment:

Thanks for the heads up, I kind of forgot about migrating that branch. It's there now. I will merge the changes in master into the feature branch.

I've been hesitant about merging the feature into master because it adds noticeable complexity for what seems to be a niche feature. But I can be convinced that it's worth the complexity by having interested people vote (thumbs-up this comment) or share their use cases (ideally with source links).

@speter speter changed the title feature branch user_vars missing user-provided variables (branch feature/user_vars) -- vote for inclusion in master Aug 12, 2016
@speter
Copy link
Contributor

speter commented Aug 12, 2016

Moved to PR #9; please discuss there further.

@speter speter closed this as completed Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants