Skip to content
This repository was archived by the owner on Apr 4, 2022. It is now read-only.

Explorer: Transaction viewer #780

Closed
7 of 8 tasks
alfetopito opened this issue Oct 18, 2021 · 6 comments
Closed
7 of 8 tasks

Explorer: Transaction viewer #780

alfetopito opened this issue Oct 18, 2021 · 6 comments
Assignees
Labels
app:Explorer Explorer App Epic Protofire task to the protofire team

Comments

@alfetopito
Copy link
Contributor

alfetopito commented Oct 18, 2021

Description

Implement Transaction viewer page on Gnosis Protocol Explorer

First step towards batch view tool.

For now, we should only list all orders that were settled in a single blockchain transaction

Additional resources

New endpoint from backend returning all orders settled in a given transaction
https://protocol-rinkeby.dev.gnosisdev.com/api/#/default/get_api_v1_transactions__txHash__orders
/api/v1/transactions/{txHash}/orders

Feature breakdown
It includes:

Good to have:

@alfetopito alfetopito added Epic app:Explorer Explorer App Protofire task to the protofire team labels Oct 18, 2021
@alfetopito alfetopito changed the title Transaction viewer Explorer: Transaction viewer Oct 19, 2021
@alfetopito alfetopito assigned alfetopito and alongoni and unassigned alfetopito Nov 9, 2021
@alongoni
Copy link
Contributor

alongoni commented Nov 17, 2021

Hey @alfetopito. Here is a first approach to the tx viewer:
UI_Explorer v1  - TX viewer

Should we need to add some relevant information from here?
image

@alfetopito
Copy link
Contributor Author

Thanks Agustin!

As I mentioned the other day in the meeting, we don't have right now a "list" of transactions from the contract.
This can be a next step and your UI fits great into that.

For now, a "detailed" transaction view is enough.

By that I mean a view that only shows a list of orders, for a single transaction. Basically the inner content, without search or pagination
screenshot_2021-11-17_13-32-31

And on top similar to orders
screenshot_2021-11-17_13-33-59
(It would say instead of Order -> Transaction details)
Also a link to etherscan to see the transaction there.

And as a next step we can expand and show the list of batches as you have suggested now

@biocom anything you'd like to add?

@alongoni
Copy link
Contributor

Thanks @alfetopito. Design updated.
UI_Explorer v1  - TX viewer

@alfetopito
Copy link
Contributor Author

Perfect @alongoni !

Unless anyone on @gnosis/gp-frontend has any comments, it's ready for implementation.

@anxolin
Copy link
Contributor

anxolin commented Nov 18, 2021

It looks great, would it make sense to have some header with some basic information. In the future it could have the basic stats of the batch, like traded volume. Right now, it's easy to show the Tx hash, date, block number? (probably not), number of orders, number of different accounts, total fees, and list of involved tokens.

However, probably we want to start without the header and reiterate later. Maybe even give a try to the graph :)

Anyways, nice one! im looking forward for this feature

@alfetopito
Copy link
Contributor Author

Right now, it's easy to show the Tx hash, date, block number? (probably not), number of orders, number of different accounts, total fees, and list of involved tokens.

All of that seems pretty low effort fetched from the chain and would be great to have!

Still, I'd be happy to have just the simple version right now as it'll be a big plus.

So Agustin, you can work in parallel on Anxo's suggetion but the team is unblocked to start implementing the base version if there are resources available.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:Explorer Explorer App Epic Protofire task to the protofire team
Projects
None yet
Development

No branches or pull requests

4 participants