This repository was archived by the owner on Jun 24, 2022. It is now read-only.
Custom theme override #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velenir
approved these changes
Nov 3, 2020
| @@ -22,20 +22,20 @@ import { | |||
|
|
|||
| export const ButtonPrimary = styled(ButtonPrimaryMod)` | |||
| // CSS overrides | |||
| ${({ theme }) => theme.linearGradient} | |||
There was a problem hiding this comment.
This isn't quite obvious that linearGradient = 'background-image:...', maybe call it bckImageGradient
Or use like background-image: ${({ theme }) => theme.linearGradient}
anxolin
changed the base branch from
import-them-as-global
to
custom-theme-michel
anxolin
added a commit
that referenced
this pull request
Nov 3, 2020
* Add modified header * Add header modification * Override logos * Leave header placeholder * Create type WithClasss * Make header styled component compatible * Remove relative path * Override body * Adding custom bg colors. * Override and re-style CurrencyInputPanel * Adding custom colors Currency Panel * Fix style not applying * Adding custom colors Currency Panel * Add currency select logic * Adding custom button gradient color. * Adding custom button component. * Fix buttons * Adding custom button component styles. * Add light mode advancedBG color. * Import theme as global (#21) * Custom theme override (#22) * Import theme as global * Override theme * Use linear gradient * Add message to reviewers * Fix issue witht he gradient * Rename linear background Co-authored-by: Anxo Rodriguez <[email protected]> Co-authored-by: Michel Bio <[email protected]>
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overrides the theme and restore the original files so we have less conflicts when we update
custom/index.tsxwill allow us to:colorsfunction: Define our own colors. Inherits from the default Uniswap colors, adds the colors added on Customize theme #8themefunction: Define our own theme snippets. See how I addressed the DRY issue for thelinear-gradientraised in Customize theme #8 . Inherits from the default Uniswap theme. This is applied inButton/index.tsxFixedGlobalStyle: inherit from Uniswap global styles, and can redefine global stylesThemedGlobalStyle: inherit from Uniswap global styles, and can redefine global styles. I applied here the changes from Customize theme #8. Note that it adds a TODO of something I think is an error, but not part of this PR (comes from Customize theme #8 too)