Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Implement gas estimation display/notification on UI #1693

Closed
elena-zh opened this issue Oct 26, 2021 · 4 comments
Closed

Implement gas estimation display/notification on UI #1693

elena-zh opened this issue Oct 26, 2021 · 4 comments
Labels
app:CowSwap CowSwap app Enhancement New feature or request Low Severity indicator for defects. It won't cause any major break-down of the system Protofire Handled by Protofire development team

Comments

@elena-zh
Copy link

Design was implemented and discussed in #1375

Right now, CowSwap users have no way to tell (using the UI alone) what's the current gas price.
Although orders placed cost no gas, the fees charged on the execution are dependent on gas prices.
So it might still not be a good idea to place an order during gas spikes, as you can spend a large amount in the trade you might not want to.

On top of that, when Smart contract wallet orders are integrated, these users will have to send onchain txs when placing orders.

@elena-zh elena-zh added app:CowSwap CowSwap app Protofire Handled by Protofire development team Enhancement New feature or request labels Oct 26, 2021
@alongoni alongoni added the Low Severity indicator for defects. It won't cause any major break-down of the system label Dec 2, 2021
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you think it shouldn't be closed, speak now or forever hold your peace.

@stale stale bot added the wontfix Stale issue label Mar 2, 2022
@elena-zh
Copy link
Author

elena-zh commented Mar 2, 2022

@alfetopito , do we still have this task in the priority list, or should we close this for now?

@stale stale bot removed the wontfix Stale issue label Mar 2, 2022
@alfetopito
Copy link
Contributor

Uniswap has added it and since I'm merging with their latest updates, we should get this for "free"

Check the bottom right of their app:
Screen Shot 2022-03-02 at 11 08 26

@elena-zh
Copy link
Author

elena-zh commented Mar 3, 2022

Cool, thanks!
I'm closing the task then.

@elena-zh elena-zh closed this as completed Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Enhancement New feature or request Low Severity indicator for defects. It won't cause any major break-down of the system Protofire Handled by Protofire development team
Projects
None yet
Development

No branches or pull requests

3 participants