Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Rounding amounts are different on swap form and confirm modal when 'Max' token value is selected #1332

Open
elena-zh opened this issue Aug 26, 2021 · 2 comments
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system wontfix Stale issue

Comments

@elena-zh
Copy link

Originally reported and discussed here #1281 (comment)

Low-low priority

Although, more than 4 decimals are considered as an expected behavior when fill in a field with a Max token value, I'd like to mention the next case:
token value is not rounded in the Swap form, however, it appears to be rounded in the confirmation modal
max.jpg
max 2.jpg

IMO, rounding should be the same..

@elena-zh elena-zh added app:CowSwap CowSwap app Low Severity indicator for defects. It won't cause any major break-down of the system Bug Something isn't working labels Aug 26, 2021
@alfetopito
Copy link
Contributor

The thing is, on user input there's no rounding. On summary there is.
Also, on summary the title with full amounts is available (on desktop)

@stale
Copy link

stale bot commented Mar 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you think it shouldn't be closed, speak now or forever hold your peace.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system wontfix Stale issue
Projects
None yet
Development

No branches or pull requests

2 participants