Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Fees are displayed when select an unsupported token #1278

Open
elena-zh opened this issue Aug 18, 2021 · 3 comments
Open

Fees are displayed when select an unsupported token #1278

elena-zh opened this issue Aug 18, 2021 · 3 comments
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@elena-zh
Copy link

elena-zh commented Aug 18, 2021

Low priority as it might be an edge case

  1. Select a token to sell (supported), specify an amount to sell
  2. select an unsupported token in the To field
  3. change a token in the To field to a supported one
  4. again, change the To token to an unsupported token in the list

AR: Price and Fee fields are displayed along with the 'Unsupported token' message
Video: https://drive.google.com/file/d/1I941Aaztb7JDyZo6bIQBvqFFxYWx8Fpo/view
prices.jpg

ER: Price and Fee fields are not displayed along with the 'Unsupported token' message

@elena-zh elena-zh added app:CowSwap CowSwap app Low Severity indicator for defects. It won't cause any major break-down of the system Bug Something isn't working labels Aug 18, 2021
@elena-zh
Copy link
Author

Besides, a message about an unknown price impact is displayed
image

Expected: no such a message when a token in not supported.

@alfetopito
Copy link
Contributor

This is interesting.
I think we didn't use to have any data when the token was unsupported so this case was never handled.

Maybe this changed recently @anxolin @W3stside

@elena-zh
Copy link
Author

Just to clarify: the issue is an edge one, that is why it has a low priority.
You will be able to reproduce it by following the exact steps in the description (you need to change a token pair several times).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Development

No branches or pull requests

2 participants