Amounts on the waiting pop-up and sent to the connected wallet are different

[elena-zh]

Reproducible in Prod/Stage

1. Specify From/To tokens, an amount to sell
2. Press on the Swap button
3. Verify amounts
4. Confirm the transaction
5. Check numbers on the Waiting pop-up and in the connected wallet

AR: in several seconds numbers on the waiting modal might be changed (I believe, due to prices are changed).
However, user needs to sign the transaction with previous amounts in the connected wallet

ER: amounts should be the same

[anxolin]

That message should be expressed in "at least" / "at most" terms (so showing what you sign)

We will not include this in the version, but I believe we should fix it asap. Maybe we could show this message like:

Sell order

Swapping XXXX for YYYY.
   Minimum received (incl. fee): ZZZZZZ

Buy order

Swapping XXXX for YYYY.
   Maximum sent (incl. fee): ZZZZZZZ

@biocom @alfetopito @W3stside WDYT?

[alfetopito]

That's a nice improvement.

I'm also fine using the min/max-receive everywhere to be consisted with what's signed.
AFAIAA, the notification also needs to be updated

[MareenG]

I noticed that the value is not just off it changes with time. I guess the value is not frozen but updates according to fee changes.
Usually it takes quite a while until the price is udated but in the case displayed below it changes rather fast.

Confirmation.mov

[alfetopito]

Hmm good point.
We should "lock" the amounts in the tx pending modal, since the tx signing was already triggered.

Makes sense to update them in the confirmation modal as it's not yet final, but not after that.

[anxolin]

@MareenG great catch. I think this is super important to fix! Once you are in the confirmation, we should never change the prices without asking the user to ACCEPT them.

@W3stside, this should be something important to add to our next ones.

[MareenG]

It actually disappears when the fee amount surpasses the from token

[elena-zh]

Hey @W3stside , here is another issue related to Waiting for Confirmation modal, that might be fixed along with this task: #1215.
Could you please take a look at it?

[elena-zh]

Still reproducible in a new activity modal