fix: Change UpdatePassword to take multiple addresses, roll back on error #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefft0
force-pushed
the
fix/UpdatePassword-rollback
branch
from
49a15b5 to
229982a
Compare
…rror Signed-off-by: Jeff Thompson <[email protected]>
jefft0
force-pushed
the
fix/UpdatePassword-rollback
branch
from
229982a to
68b0b75
Compare
Signed-off-by: Jeff Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Change
UpdatePasswordto take an array of addresses, roll back on error.Explanation: Currently,
UpdatePasswordtakes a single address of the account to update the password. If a native application wants to change multiple accounts to the new password, it does a loop to callUpdatePasswordmultiple times. But if one of the calls has an error, the application breaks out of the loop and leaves the Keybase in an inconsistent state where some passwords are changed but not all. The application could write some logic to roll back these changes, but it is better for the Gno Native Kit service to handle this.This PR has two commits:
UpdatePasswordrequest to take a required array of account addresses. (If the application only wants to update the password of one account, it is easy to make an array of one address.) In api.go, we also changeUpdatePasswordto roll back to the old password in case of error.updatePasswordto take a required array of Uint8Array for the addresses.