Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Gnoboard #174

Merged

Conversation

D4ryl00
Copy link
Contributor

@D4ryl00 D4ryl00 commented Sep 5, 2024

This PR fixes the example app gnoboard with the latest changes in gnonative:

  • update to Expo 51 to be compatible with Xcode 15.3 or above.
  • use the Buf'registry gnonative API instead of getting locally in the parent directories (it was too hacky and not stable enough). It also has the advantage that new applications can use the GnoNativeApi file which is in the expo folder, allowing us to only maintain one file for the typescript API.

Note: the app will continue to use @bufbuild/protobuf v1.7.2 instead of the v2 because @connectrpc/connect and @connectrpc/connect-web are only available on version v1... and not v2 yet.

@D4ryl00 D4ryl00 self-assigned this Sep 5, 2024
@D4ryl00 D4ryl00 marked this pull request as draft September 5, 2024 09:34
@D4ryl00 D4ryl00 force-pushed the chore/update-gnoboard-with-latest-changes branch from 11e14e6 to efc7fb0 Compare September 5, 2024 09:36
@D4ryl00 D4ryl00 marked this pull request as ready for review September 5, 2024 09:39
@D4ryl00 D4ryl00 requested a review from jefft0 September 5, 2024 09:40
@jefft0 jefft0 requested a review from iuricmp September 5, 2024 12:08
Copy link
Contributor

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android and iOS simulators.

Copy link
Contributor

@iuricmp iuricmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @D4ryl00 ! 🚀

@D4ryl00 D4ryl00 merged commit 15d9089 into gnolang:main Sep 11, 2024
@D4ryl00 D4ryl00 deleted the chore/update-gnoboard-with-latest-changes branch September 11, 2024 09:13
Copy link

🎉 This PR is included in version 1.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@D4ryl00 D4ryl00 mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants