Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update expo to use any activated account #173

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

jefft0
Copy link
Contributor

@jefft0 jefft0 commented Sep 4, 2024

PR #172 update the API to support using any activated account. We need to update the expo provider to the same API. This PR has 3 commits:

  1. Update go.mod to use the latest gnokey-mobile following changes in PR fix: Use the latest gnonative to call ClientSignTx gnokey-mobile#9
  2. In expo, npm install the latest gnolang_gnonative.bufbuild_es and connectrpc_es to access the new API
  3. Update expo/src/api/GnoNativeApi.ts to match the new API to use any activated account, specified by address. Note that the address parameters are optional for temporary backwards compatibility. When dSocial and Gnokey Mobile are updated to use the new API and specify the address, we will do a PR to require the address parameter, and to remove the deprecated selectAccount and getActiveAccount.

@jefft0 jefft0 requested a review from D4ryl00 September 4, 2024 09:00
Copy link
Contributor

@D4ryl00 D4ryl00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jefft0 jefft0 merged commit ff1fda7 into gnolang:main Sep 4, 2024
@jefft0 jefft0 deleted the feat/expo-use-any-activated-account branch September 4, 2024 09:49
Copy link

github-actions bot commented Sep 4, 2024

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants