Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test verifying go list of dependencies on cmd/gnoland doesn't contain tests/stdlibs #3585

Closed
kristovatlas opened this issue Jan 22, 2025 · 0 comments · Fixed by #3589
Closed
Labels
security Security-sensitive issue

Comments

@kristovatlas
Copy link
Contributor

Description

We have methods on std that are intended to be used for testing, but theoretically they could be misused from VM normal execution, e.g. std.TestSetRealm.

These methods are not currently compiled into the gnoland binary, but to avoid accidental regression in the future, we can add a test to ensure that a go list of dependencies on cmd/gnoland doesn't contain tests/stdlibs.

Suggestion from @ajnavarro and @thehowl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Security-sensitive issue
Projects
Development

Successfully merging a pull request may close this issue.

1 participant