Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a notification to the user if they are trying to report a bug with an URL which is going to be too big #151

Open
NatElkins opened this issue Nov 18, 2024 · 3 comments

Comments

@NatElkins
Copy link
Contributor

Steps to repro:

  1. Navigate to https://glutinum.net/
  2. Paste in the index.d.ts file for vscode. It's about 20K lines.

Click Report issue. On FF nothing happens, on Chrome the following happens:

image
@MangelMaxime
Copy link
Contributor

This is probably a limitation coming from the Browsers because the URL is too long. There is also a limitation on Github side on how big the URL can be to create an issue.

I also prefer issues to be trim down to the problem instead of having a big file to manually filter myself.

For all these reason, I don't think there is something to do about this issue.

@NatElkins
Copy link
Contributor Author

Gotcha, that makes sense. I do think a size limit that is displayed to the user might be useful. When it didn't work I was scratching my head for a bit.

@MangelMaxime MangelMaxime changed the title Report issue button on website doesn't work with very large inputs Display a notification to the user if they are trying to report a bug with an URL which is going to be too big Nov 19, 2024
@MangelMaxime
Copy link
Contributor

It should indeed be possible to add a toast to notify that the URL is too big.

I will first test by using Github max length because to me this is the URL length that we care the most about. And hopefully, it will also cover the browsers too

@MangelMaxime MangelMaxime reopened this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants