-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for linking BaseCartersianData instances #2326
Comments
One of the main considerations here is that I think in the generic case we don't want to be adding/removing components from datasets based on links (see http://docs.glueviz.org/en/stable/developer_guide/linking.html for some examples). We can probably retain the API of Another thing to think about is how we will deal with: https://github.com/glue-viz/glue/blob/main/glue/core/fixed_resolution_buffer.py#L51 in the fixed resolution buffer code - I think here again we will need to have a way to query the link manager for the transformation function from one component ID to another (which is maybe what we need above too). So perhaps the first place to start is to determine whether we can add something to the link manager that will find the transformation from one component ID to another and/or transform values. |
I think what we might want to do is basically modify: glue/glue/core/link_manager.py Lines 236 to 242 in 38fa849
so that it stores it in an internal object rather than adding components to the dataset (at least it would only add derived components for the |
In fact thinking about this more I think we can actually just store the externally derived components inside the BaseCartesianData objects and just not expose the components directly, similar to what we do for world coordinates. |
Done in #2328 |
Thanks! What should Jdaviz expect from this? Would you open a POC PR downstream in Jdaviz with this new functionality? |
Yes I will show how to use this shortly |
Linking doesn't currently work properly with BaseCartesianData instances because we don't store any e.g. Component objects on the data - as we need to think of the data API as being analogous to a read-only API (so that it works properly with e.g. web data objects and so on). We should add support for linking BaseCartesianData objects.
The text was updated successfully, but these errors were encountered: