Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with signac 2.0 #132

Closed
cbkerr opened this issue May 6, 2022 · 1 comment · Fixed by #153
Closed

Compatibility with signac 2.0 #132

cbkerr opened this issue May 6, 2022 · 1 comment · Fixed by #153

Comments

@cbkerr
Copy link
Member

cbkerr commented May 6, 2022

Running list of things that need to be changed for signac 2.0 (next branch)

  • remove reliance on project titles
  • use job_id instead of jobid everywhere
@bdice
Copy link
Member

bdice commented May 6, 2022 •
edited
Loading

To the best of my recollection, the jobid to job_id one is just for internally consistent style, not necessarily for signac 2.0 compatibility.

Some other changes will involve using project.path and job.path, most likely.

@cbkerr cbkerr mentioned this issue Oct 18, 2022
Merged
5 tasks
@cbkerr cbkerr mentioned this issue Oct 26, 2022
Closed
5 tasks
@bdice bdice closed this as completed in #153 Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compatibility with signac 1.8 glotzerlab/signac-dashboard
2 participants
@bdice @cbkerr