Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardware subtypes should permit multiple values #45

Closed
glennmatthews opened this issue May 24, 2016 · 1 comment
Closed

Hardware subtypes should permit multiple values #45

glennmatthews opened this issue May 24, 2016 · 1 comment
Assignees

Comments

@glennmatthews
Copy link
Owner

OVFs can specify multiple subtypes for a device (allowing the target host to choose which subtype it prefers/supports):

        <rasd:ResourceSubType>virtio E1000</rasd:ResourceSubType>

but cot edit-hardware doesn't presently provide this option:

$ cot edit-hardware foo.ova --nic-type e1000 virtio
cot: error: unrecognized arguments: virtio
$ cot edit-hardware foo.ova --nic-type "e1000 virtio"
cot edit-hardware: error: argument --nic-type: invalid choice: 'e1000 virtio' (choose from 'e1000', 'virtio', 'vmxnet3')
$ cot edit-hardware foo.ova --nic-type "e1000, virtio"
cot edit-hardware: error: argument --nic-type: invalid choice: 'e1000, virtio' (choose from 'e1000', 'virtio', 'vmxnet3')
$ cot edit-hardware foo.ova --nic-type e1000 --nic-type virtio
# accepted as valid but the resulting OVA only has virtio subtype
@glennmatthews
Copy link
Owner Author

Fixed in v1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant