Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking 1.1 #74

Open
17 of 26 tasks
glenjamin opened this issue Apr 21, 2016 · 6 comments
Open
17 of 26 tasks

Tracking 1.1 #74

glenjamin opened this issue Apr 21, 2016 · 6 comments
Assignees

Comments

@glenjamin
Copy link
Owner

glenjamin commented Apr 21, 2016

Braindump of actions, will expand on these as I go.

  • Document breaking API changes
  • Make the breaking changes
    • subTreeLike has been renamed to subTree
    • everySubTreeLike has been renamed to everySubTree
    • The original subTree has been removed, exact can be used to get this behaviour back, but I don't recommend you do.
    • The original subTreeLike has been removed, exact can be used to get this behaviour back, but I don't recommend you do.
    • removed findNode, use subTree instead
    • removed textIn, use subTree().text() instead
    • removed fillField, use subTree().props.onChange instead
    • removed findComponent, use subTree() instead
    • removed findComponentLike, use subTree() instead
    • toString() no-longer expands child components Better tostring output #26
    • reRender() now takes props instead of a ReactElement.
  • Implement the new APIs
    • .exact()
    • .any()
    • .hasClass()
  • Fully document the new & remaining APIs
    • Matchers
    • Selectors
  • Ensure all APIs have decent test coverage
  • Extract traversal code into an internal module and test on its own Rejig the test suite #23
  • Write a migration guide
  • Merge to the master branch
  • Publish a beta to npm
  • Standardise with proper linting rules proper linting in the CI build #41
@glenjamin glenjamin mentioned this issue Apr 22, 2016
@glenjamin glenjamin self-assigned this Apr 27, 2016
@burabure
Copy link

Hey, are you still planning on releasing 1.0?, let me know If I can help with some task

@glenjamin
Copy link
Owner Author

Still intend to, not been doing any React component testing lately so it's slipped a bit,

Either extra test coverage, porting older tests over to the new test style or implementing the new APIs would be useful

@indexzero
Copy link

Given your time constraints if I may be so bold as to suggest a few things:

  1. Implement your the remaining new APIs (.exact, .any, and .hasClass) in 1.1 The API documented in the README.md on master seems like it would solve most scenarios as is.
  2. Publish your beta now so folks can use it. You can always publish another beta later on.

@glenjamin
Copy link
Owner Author

Yeah, implementing those is all that's really missing for a beta release.

I think I published what's here so far as a next tag on npm.

Its been really sunny here lately so I've not been coding as much!

@glenjamin
Copy link
Owner Author

I've just added hasClass and published [email protected].

Will try not to let this slip much more ☀️

@indexzero
Copy link

Awesome. Appreciate your hard work.

@glenjamin glenjamin changed the title Tracking 1.0 Tracking 1.1 Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants