Godot 3.5 : Error when switching between inherited scenes

[BasileAltar]

Describe the bug
Please note that I am still on Godot 3.5 until my project is over. I do not expect a bug correction on this version, but rather a quick workaround if you know any.

When calling change_scene() between two inherited scenes, the scene replacement works as intended, but an error is shown in the debugger :

The error is on the instruction _root.add_child() :

Every time I call change_scene, the same error is repeated, but again the scene replacement works as intended.

To Reproduce
On Godot 3.5

1. Have two Node2D scenes.
2. Create an inherited scene from each scene (scene -> new inherited scene)
3. Attach a script to a child scene, then call change_scene from the scene to the other child scene
4. The scene replacement works as intended, but an error appears in the stacktrace.
5. Call change_scene multiple times to get multiple errors.
6. The error does not appear when calling change_scene between non-inherited scenes.

Expected behavior
The scene switch should happen with no error.
I would either like to solve the error, or to know if I can safely keep it.

Screenshots
The code to change scene (event fired from a Node2D collision)

The target inherited scene

The base scene

Desktop

• Windows 10

Additional context
Godot 3.5

[Villagerjj]

this bug is also present in godot 4.2.2, I am going to do some investigating

[Villagerjj]

UPDATE:
this "fixes" the issue, only for the first scene transition in your game, any other attempts fail, use at your own risk!

I replace the code in the _replace_scene function with this code:

	_current_scene.queue_free()
	scene_unloaded.emit()
	var following_scene: PackedScene = ResourceLoader.load(path, "PackedScene", 0)
	var temp_current_scene = following_scene.instantiate()
	_current_scene = temp_current_scene
	_current_scene.tree_entered.connect(options["on_tree_enter"].bind(_current_scene))
	_current_scene.ready.connect(options["on_ready"].bind(_current_scene))
	await _tree.create_timer(0.0).timeout
	_root.add_child(temp_current_scene)
	_tree.set_current_scene(_current_scene)

this seems to keep all the logic in order

[jabsatz]

Hello, thanks for the report and the fix (and sorry for the late reply). Does your fix work correctly or did you run into any further issues? We might just add that code directly into the 3.x branch in that case, if you'd like to do it PRs are also welcome here!

I just made a blog post here explaining the situation of this plugin #35