You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi hi
I was looking at this lib (got here through a post in Medium)
And it looks really good and simple.
The only thing that I'm missing in order to put in my production app is the testing.
I need to guarantee that the component will not break my app, or that accidentally the usage API has been changed.
The tests will make sure nothing breaks, and if the usage is changed - this will help indicate that probably a major version needs to change.
(I currently don't have the time to help with the testing implementation itself, but feel free to contact me for guidance or moral support :D)
Well done on the lib 👍
The text was updated successfully, but these errors were encountered:
I don't have tests for this mostly because it's a 50 line file that was written a few years ago and has barely changed since. Quite frankly, the surface area is tiny, I don't worry much about things going wrong, and writing tests seems like overkill. For what it's worth, I run the example server and do visual QA every time I push an update. But your skepticism is correct here.
Because its so small, I'd encourage you (and those who see this in the future) to consider copying the contents of FadeIn.js into your project directly instead of adding this to your package.json. For the reasons you outlined (what if something breaks?), we should probably all be more wary of pulling in tiny dependencies for one-off features.
Hi hi
I was looking at this lib (got here through a post in Medium)
And it looks really good and simple.
The only thing that I'm missing in order to put in my production app is the testing.
I need to guarantee that the component will not break my app, or that accidentally the usage API has been changed.
The tests will make sure nothing breaks, and if the usage is changed - this will help indicate that probably a major version needs to change.
(I currently don't have the time to help with the testing implementation itself, but feel free to contact me for guidance or moral support :D)
Well done on the lib 👍
The text was updated successfully, but these errors were encountered: